Repository navigation
test(training-agent): derive validator-gate seed passes from fixtures - #7976
Conversation
The drift test from #7541 hard-coded 14 and 18 seed_product passes. The @adcp/sdk 14.2 runner also seeds each fixture account through the controller, so /brand and /governance now earn 15 and 19 passes, and main fails Server integration tests (3/4). Count fixture products plus fixture accounts and accept seed_account steps alongside seed_product. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![aao-secretariat[bot]](https://avatars.githubusercontent.com/u/221690821?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — single test-only fix with no blocking or medium findings.
This PR touches one file: server/tests/integration/training-agent-tool-catalog-drift.test.ts (+7/-5). It derives the expected validator-gate seed count from fixtures (products + accounts) instead of re-hardcoding, and widens the pass check to accept seed_account.* alongside seed_product.* to match the @adcp/sdk 14.2 runner that now seeds fixture accounts as controller passes. The toBeGreaterThan(0) guard prevents a vacuous assertion.
Checks:
- No published-surface change (no
static/schemas/source/**,docs/reference/**,dist/**, or task/compliance assets) — no changeset required. - high_risk: false; gated_paths: false.
- No no-auto-approve team match.
- Reviewer surfaced zero findings.
Decision table: rows 1–8 do not fire (no critical/high/medium findings, no gated paths, no high-risk deletion/modification, no team gate). Note review_decision is REVIEW_REQUIRED, but with gated_paths false that does not block (deprecated protected-branch rule removed). Falls through to row 9 → approve.
Summary
mainhas failedServer integration tests (3/4), a required check, since #7541 (9d726b51, thencc2d5b8d):The test hard-coded the passes the old
validate_input OR comply_test_controllergate earned: 14 forctv-experience-validate-inputand 18 forpremium-display-canonical-validation, all of themseed_product.*steps. Each storyboard also has onefixtures.accountsentry, and the@adcp/sdk14.2 runner (#7931) seeds it as a passingseed_account.*controller step. That makes 15 and 19 passes.The test now:
seed_account.*alongsideseed_product.*as controller setup passes.The rest of the assertion is unchanged: every pass is still a controller seed, and every validator step is still skipped as
missing_tool.Validation
npx vitest run server/tests/integration/training-agent-tool-catalog-drift.test.ts: 11/11 pass. The same command on unmodifiedmaingives 2 failures (expected 15 to be 14).npm run typecheckpasses.This also unblocks #7953 and every other PR into
main.🤖 Generated with Claude Code
Open workspace in Conductor